sd4324530 commented on code in PR #2419: URL: https://github.com/apache/fluss/pull/2419#discussion_r2710846398
########## fluss-filesystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/exception/InvalidCredentialsException.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.fs.s3.exception; + +/** Exception thrown when no credentials were found. */ +public class InvalidCredentialsException extends RuntimeException { + + public static final String E_NO_AWS_CREDENTIALS = "No AWS Credentials"; + + public InvalidCredentialsException(String credentialProvider) { Review Comment: Thank you so much for reminding me. I checked it again carefully. Fluss v0.8 depends on hadoop version 3.3.4. I found that the inheritance chain of `NoAwsCredentialsException` has changed when upgrading from 3.3.4 to 3.4.0: hadoop 3.3.4: ```mermaid classDiagram direction RL class AmazonClientException class CredentialInitializationException class NoAuthWithAWSException class NoAwsCredentialsException AmazonClientException --|> CredentialInitializationException CredentialInitializationException --|> NoAuthWithAWSException NoAuthWithAWSException --|> NoAwsCredentialsException ``` hadoop 3.4.0: ```mermaid classDiagram direction RL class SdkClientException class CredentialInitializationException class NoAuthWithAWSException class NoAwsCredentialsException SdkClientException--|> CredentialInitializationException CredentialInitializationException --|> NoAuthWithAWSException NoAuthWithAWSException --|> NoAwsCredentialsException ``` In Hadoop 3.3.4, `AmazonClientException` originates from `aws-java-sdk-core-1.12.319.jar`, which is only 1MB in size. In Hadoop 3.4.0, `SdkClientException` originates from `bundle-2.23.19.jar`, which is 500+MB in size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
