affo commented on code in PR #2456:
URL: https://github.com/apache/fluss/pull/2456#discussion_r2720703460
##########
helm/values.yaml:
##########
@@ -47,6 +47,10 @@ persistence:
size: 1Gi
storageClass:
+# Tablet server only configuration options
+tabletServer:
Review Comment:
Just a suggestion, it looks to me that `persistence` is also a tablet server
configuration.
Wouldn't it be better to have:
```yaml
tablet:
numberOfReplicas:
storage:
enabled:
size:
class:
```
##########
helm/values.yaml:
##########
@@ -47,6 +47,10 @@ persistence:
size: 1Gi
storageClass:
+# Tablet server only configuration options
+tabletServer:
Review Comment:
@swuferhong what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
