affo commented on code in PR #2456:
URL: https://github.com/apache/fluss/pull/2456#discussion_r2736000278


##########
helm/values.yaml:
##########
@@ -47,6 +47,10 @@ persistence:
   size: 1Gi
   storageClass:
 
+# Tablet server only configuration options
+tabletServer:

Review Comment:
   @swuferhong `persistence` is the current key in `values.yaml`:
   
   ```
   persistence:
     enabled: false
     size: 1Gi
     storageClass:
   ```
   
   And it is a top-level key.
   
   What I am suggesting here is to group multiple tablet-relevant configs under 
`tablet`.
   In any case we would need:
   
   ```
   tablet:
     numberOfReplicas:
   
   coordinator:
     numberOfReplicas: # for HA
   ```
   
   At this point, we may extend `tablet` to include the current `persistence` 
values.
   Does this make sense to you?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to