luoyuxia commented on code in PR #214:
URL: https://github.com/apache/fluss-rust/pull/214#discussion_r2729918443
##########
crates/fluss/src/client/table/partition_getter.rs:
##########
@@ -17,40 +17,186 @@
use crate::error::Error::IllegalArgument;
use crate::error::Result;
-use crate::metadata::{DataType, RowType};
+use crate::metadata::{DataType, ResolvedPartitionSpec, RowType};
+use crate::row::InternalRow;
use crate::row::field_getter::FieldGetter;
+use crate::util::partition;
+/// A getter to get partition name from a row.
#[allow(dead_code)]
-pub struct PartitionGetter<'a> {
- partitions: Vec<(&'a String, &'a DataType, FieldGetter)>,
+pub struct PartitionGetter {
+ partition_keys: Vec<String>,
Review Comment:
Agree. I think we can consider in another pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
