leekeiabstraction commented on code in PR #214:
URL: https://github.com/apache/fluss-rust/pull/214#discussion_r2731187866
##########
crates/fluss/src/metadata/partition.rs:
##########
@@ -240,7 +241,7 @@ impl ResolvedPartitionSpec {
}
fn get_reordered_partition_values(
- partition_keys: &[String],
+ partition_keys: &Arc<[String]>,
Review Comment:
Let's hold this off, it's hard-ish to tell what best arg type to use until
everything is wired together. I might even remove this function in the final
wiring PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
