leekeiabstraction commented on code in PR #220:
URL: https://github.com/apache/fluss-rust/pull/220#discussion_r2745060032
##########
crates/fluss/src/client/write/sender.rs:
##########
@@ -392,15 +393,15 @@ impl Sender {
for bucket in pending_buckets {
if let Some(ready_batch) = records_by_bucket.remove(&bucket) {
- if let Some((table_path, physical_table_path)) = self
+ if let Some(physical_table_path) = self
.handle_write_batch_error(
ready_batch,
FlussError::UnknownServerError,
format!("Missing response for table bucket {bucket}"),
)
.await?
{
- invalid_metadata_tables.insert(table_path);
+
invalid_metadata_tables.insert(physical_table_path.get_table_path().clone());
Review Comment:
Java side updates based on both TablePath and PhysicalTablePath:
https://github.com/apache/fluss/blob/3a803dfd812398decbfbced81b655d6a8839351e/fluss-client/src/main/java/org/apache/fluss/client/metadata/MetadataUpdater.java#L231-L240
Here we have `invalid_metadata_tables` which tracks invalid TablePath and
`invalid_physical_table_paths` which tracks invalid PhysicalTablePath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
