MehulBatra commented on code in PR #2525: URL: https://github.com/apache/fluss/pull/2525#discussion_r2749260114
########## fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/deserializer/BinlogDeserializationSchema.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.source.deserializer; + +import org.apache.fluss.flink.utils.BinlogRowConverter; +import org.apache.fluss.record.LogRecord; +import org.apache.fluss.types.RowType; + +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; + +import javax.annotation.Nullable; + +import static org.apache.fluss.flink.utils.FlinkConversions.toFlinkRowType; + +/** + * A deserialization schema that converts {@link LogRecord} objects to Flink's {@link RowData} + * format with nested before/after row structure for the $binlog virtual table. + * + * <p>This schema is stateful: it buffers UPDATE_BEFORE (-U) records and returns {@code null} for + * them. When the subsequent UPDATE_AFTER (+U) record arrives, it merges both into a single binlog + * row. The {@link org.apache.fluss.flink.source.emitter.FlinkRecordEmitter} handles null returns by + * skipping emission. Review Comment: Thank you @wuchong, for the quick feedback. I will go through and address them one by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
