MehulBatra commented on code in PR #2525:
URL: https://github.com/apache/fluss/pull/2525#discussion_r2751328013
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkTableFactory.java:
##########
@@ -261,11 +276,18 @@ private LakeTableFactory mayInitLakeTableFactory() {
}
/**
- * Validates table source options explicitly recognized by Flink.
+ * Validates table source options using the standard validation pattern.
*
+ * @param helper the factory helper for option validation
* @param tableOptions the table options to validate
*/
- private static void validateSourceOptions(ReadableConfig tableOptions) {
+ private static void validateSourceOptions(
+ FactoryUtil.TableFactoryHelper helper, ReadableConfig
tableOptions) {
+ Optional<DataLakeFormat> datalakeFormat =
getDatalakeFormat(tableOptions);
+ List<String> prefixesToSkip =
+ new ArrayList<>(Arrays.asList("table.", "client.", "fields.",
"binlog."));
Review Comment:
I see that after rebasing, the entire logic of prefixesToSkip has been
removed from flinkTablefactory, the helper.validateExcept() call was removed,
so there's no longer any validation that rejects unknown options or I am
missing anything here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
