xx789633 commented on code in PR #2485:
URL: https://github.com/apache/fluss/pull/2485#discussion_r2752391160
##########
fluss-server/src/main/java/org/apache/fluss/server/replica/ReplicaManager.java:
##########
@@ -633,8 +693,84 @@ public void lookups(
tb, new LookupResultForBucket(tb,
ApiError.fromThrowable(e)));
}
}
+
+ if (insertIfNotExists) {
Review Comment:
Could you please also add a comment here to indicate that there might be a
data race? The same key might be inserted by another thread after the lookup
check passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
