platinumhamburg commented on code in PR #2485:
URL: https://github.com/apache/fluss/pull/2485#discussion_r2758763392
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/partialupdate/PartialUpdater.java:
##########
@@ -100,6 +102,11 @@ private void sanityCheck(Schema schema, int[]
targetColumns) {
* @return the updated value (schema id + row bytes)
*/
public BinaryValue updateRow(@Nullable BinaryValue oldValue, BinaryValue
partialValue) {
+ if (updatePrimaryKeyOnly && oldValue != null) {
+ // only primary key columns are updated, return the old value
directly
+ return oldValue;
Review Comment:
@wuchong This optimization appears to have broken the CI tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
