leekeiabstraction commented on code in PR #298:
URL: https://github.com/apache/fluss-rust/pull/298#discussion_r2790210479
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -806,6 +807,23 @@ class Admin;
class Table;
class TableScan;
+struct Configuration {
+ // Coordinator server address
+ std::string bootstrap_server{"127.0.0.1:9123"};
+ // Max request size in bytes (10 MB)
+ int32_t request_max_size{10 * 1024 * 1024};
+ // Writer acknowledgment mode: "all" or "leader_only"
+ std::string writer_acks{"all"};
Review Comment:
Do we actually parse the value `leader_only`?
I think it's `all` or `0` or `1`. according to:
https://fluss.apache.org/docs/engine-flink/options/
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -806,6 +807,23 @@ class Admin;
class Table;
class TableScan;
+struct Configuration {
+ // Coordinator server address
+ std::string bootstrap_server{"127.0.0.1:9123"};
+ // Max request size in bytes (10 MB)
+ int32_t request_max_size{10 * 1024 * 1024};
+ // Writer acknowledgment mode: "all" or "leader_only"
+ std::string writer_acks{"all"};
+ // Max number of writer retries
+ int32_t writer_retries{std::numeric_limits<int32_t>::max()};
+ // Writer batch size in bytes (2 MB)
+ int32_t writer_batch_size{2 * 1024 * 1024};
+ // Number of remote log batches to prefetch during scanning
+ size_t scanner_remote_log_prefetch_num{4};
+ // Number of threads for downloading remote log data
+ size_t scanner_remote_log_download_threads{3};
Review Comment:
Should this be download_thread_num instead of download_threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
