fresh-borzoni commented on code in PR #298:
URL: https://github.com/apache/fluss-rust/pull/298#discussion_r2790483525
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -806,6 +807,23 @@ class Admin;
class Table;
class TableScan;
+struct Configuration {
+ // Coordinator server address
+ std::string bootstrap_server{"127.0.0.1:9123"};
+ // Max request size in bytes (10 MB)
+ int32_t request_max_size{10 * 1024 * 1024};
+ // Writer acknowledgment mode: "all" or "leader_only"
+ std::string writer_acks{"all"};
Review Comment:
good catch, my comment is wrong, implementation is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
