luoyuxia commented on code in PR #302:
URL: https://github.com/apache/fluss-rust/pull/302#discussion_r2797280817
##########
bindings/python/example/example.py:
##########
@@ -105,7 +105,7 @@ async def main():
print(f"Got table: {table}")
# Create a writer for the table
- append_writer = await table.new_append_writer()
+ append_writer = await table.new_append()
Review Comment:
also follow the pattern that
table.new_append().create_writer()?
##########
bindings/python/example/example.py:
##########
@@ -32,15 +32,15 @@ async def main():
config_spec = {
"bootstrap.servers": "127.0.0.1:9123",
# Add other configuration options as needed
- "request.max.size": "10485760", # 10 MB
+ "writer.request-max-size": "10485760", # 10 MB
"writer.acks": "all", # Wait for all replicas to acknowledge
"writer.retries": "3", # Retry up to 3 times on failure
- "writer.batch.size": "1000", # Batch size for writes
+ "writer.batch-size": "1000", # Batch size for writes
}
config = fluss.Config(config_spec)
- # Create connection using the static connect method
- conn = await fluss.FlussConnection.connect(config)
+ # Create connection using the static create method
+ conn = await fluss.FlussConnection.create(config)
Review Comment:
warn from my ide
```
Unresolved attribute reference 'create' for class 'FlussConnection'
```
we will need update `__init__.pyi`.
The same for
`TableScan.create_batch_scanner()`, `FlussTable.new_append_writer()`,
`LogScanner.poll_batches()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
