fresh-borzoni commented on code in PR #302: URL: https://github.com/apache/fluss-rust/pull/302#discussion_r2798375578
########## bindings/cpp/src/lib.rs: ########## Review Comment: I think we can be fine with ClientError for now, if we need - we can additively add new codes without breaking existing clients. Then -2 becomes the fallback. For retriable errors, we might want to add some retriable marker - this is the real need for IO/Network/Rpc level errors in the client. Or we can handle it separately if you feel it's the right move now, this PR is already becoming quite big :) ########## bindings/cpp/src/lib.rs: ########## Review Comment: I think we can be fine with ClientError for now, if we need - we can additively add new codes without breaking existing clients. Then -2 becomes the fallback. For retriable errors, we might want to add some marker - this is the real need for IO/Network/Rpc level errors in the client. Or we can handle it separately if you feel it's the right move now, this PR is already becoming quite big :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
