leekeiabstraction commented on code in PR #313:
URL: https://github.com/apache/fluss-rust/pull/313#discussion_r2805883452
##########
bindings/python/example/example.py:
##########
@@ -30,12 +30,12 @@
async def main():
# Create connection configuration
config_spec = {
- "bootstrap.servers": "127.0.0.1:9123",
+ "bootstrap_servers": "127.0.0.1:9123",
# Add other configuration options as needed
- "writer.request-max-size": "10485760", # 10 MB
- "writer.acks": "all", # Wait for all replicas to acknowledge
- "writer.retries": "3", # Retry up to 3 times on failure
- "writer.batch-size": "1000", # Batch size for writes
+ "writer_request_max_size": "10485760", # 10 MB
+ "writer_acks": "all", # Wait for all replicas to acknowledge
+ "writer_retries": "3", # Retry up to 3 times on failure
+ "writer_batch_size": "1000", # Batch size for writes
Review Comment:
Hmmm, I'm of the mind that we should keep config keys consistent even across
different languages.
I can for example envision a scenario where a Flink user using Table API in
Python attempts to read from Fluss table but refer to our documentation
(granted, it is a user error) and used the wrong key (because underlying table
api, Java connector is used).
The threading of configurations through these systems can be confusing
(though that is not what we're doing here, but we might in the future where a
default can be set on client to be added to every request) e.g.
prefixes/namespaces, changing the delimiter across different language would
make it even more challenging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
