leekeiabstraction commented on code in PR #313:
URL: https://github.com/apache/fluss-rust/pull/313#discussion_r2807299143
##########
bindings/python/src/config.rs:
##########
@@ -39,33 +39,35 @@ impl Config {
let value: String = item.1.extract()?;
match key.as_str() {
- "bootstrap.servers" => {
+ "bootstrap_servers" | "bootstrap.servers" => {
Review Comment:
Hmm, sorry for being so opinionated on this🙏🏼! I think supporting both can
get confusing too, and it's especially important to get this right since we
cannot revoke support for either after 0.1 release without risking breaking
user code.
I'll defer to Yuxia on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
