fresh-borzoni commented on code in PR #330:
URL: https://github.com/apache/fluss-rust/pull/330#discussion_r2809241298
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -232,6 +238,14 @@ struct Timestamp {
}
};
+enum class ChangeType {
+ AppendOnly = 0,
+ Insert = 1,
+ UpdateBefore = 2,
+ UpdateAfter = 3,
+ Delete = 4,
+};
+
enum class TypeId {
Review Comment:
Good idea in principle, but it would require including the CXX-generated
header in fluss.hpp, which exposes the whole FFI layer and increases
compilation time for consumers.
It's nontrivial to work around, so I'd keep it out of this PR. Happy to
explore it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
