fresh-borzoni commented on code in PR #330:
URL: https://github.com/apache/fluss-rust/pull/330#discussion_r2810106097
##########
bindings/cpp/src/types.rs:
##########
@@ -110,6 +87,8 @@ fn core_data_type_to_ffi(dt: &fcore::metadata::DataType) ->
i32 {
fcore::metadata::DataType::Timestamp(_) => DATA_TYPE_TIMESTAMP,
fcore::metadata::DataType::TimestampLTz(_) => DATA_TYPE_TIMESTAMP_LTZ,
fcore::metadata::DataType::Decimal(_) => DATA_TYPE_DECIMAL,
+ fcore::metadata::DataType::Char(_) => DATA_TYPE_CHAR,
+ fcore::metadata::DataType::Binary(_) => DATA_TYPE_BINARY,
_ => 0,
Review Comment:
Agreed that a panic here is better than silently returning 0. Will address
in a follow-up together with adding TypeId::Unknown on the C++ side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
