leekeiabstraction commented on code in PR #365:
URL: https://github.com/apache/fluss-rust/pull/365#discussion_r2839691231
##########
crates/fluss/src/row/column.rs:
##########
@@ -307,60 +344,56 @@ impl InternalRow for ColumnarRow {
precision as u32,
scale as u32,
)
- .unwrap_or_else(|e| {
- panic!(
- "Failed to create Decimal at column {} row {}: {}",
- pos, self.row_id, e
- )
- })
}
- fn get_date(&self, pos: usize) -> crate::row::datum::Date {
- crate::row::datum::Date::new(self.read_date_from_arrow(pos))
+ fn get_date(&self, pos: usize) -> Result<Date> {
+ Ok(Date::new(self.read_date_from_arrow(pos)))
Review Comment:
Great catch! Will address in subsequent rev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
