fresh-borzoni commented on code in PR #365:
URL: https://github.com/apache/fluss-rust/pull/365#discussion_r2840898915
##########
crates/fluss/src/row/mod.rs:
##########
@@ -63,58 +65,58 @@ pub trait InternalRow: Send + Sync {
fn is_null_at(&self, pos: usize) -> bool;
/// Returns the boolean value at the given position
- fn get_boolean(&self, pos: usize) -> bool;
+ fn get_boolean(&self, pos: usize) -> Result<bool>;
Review Comment:
I don't actually see the benefit of this, so we save on `?`, but at the same
time here it's not the same as in rust-postgeres, as in there you can always
trust the row - `Row` is a single concrete type with always-trusted server
data.
in fluss-rust, users input constructs GenericRow- so it's susceptible to
panics, so it makes sense to return Result for this and not have mirror surface.
But treat it as non-blocking comment, pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
