fresh-borzoni commented on code in PR #371:
URL: https://github.com/apache/fluss-rust/pull/371#discussion_r2852191318
##########
bindings/cpp/src/lib.rs:
##########
@@ -608,6 +609,7 @@ fn err_from_core_error(e: &fcore::error::Error) ->
ffi::FfiResult {
// Connection implementation
fn new_connection(config: &ffi::FfiConfig) -> Result<*mut Connection, String> {
+ // 1. Parse the bucket assigner type (the upstream feature)
Review Comment:
we don't need this context, it's only rebase/conflict fix related
##########
bindings/cpp/src/lib.rs:
##########
@@ -617,12 +619,15 @@ fn new_connection(config: &ffi::FfiConfig) -> Result<*mut
Connection, String> {
));
}
};
+
+ // 2. Build the config with BOTH your timeout and the new assigner
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
