fresh-borzoni commented on code in PR #371:
URL: https://github.com/apache/fluss-rust/pull/371#discussion_r2848438152


##########
bindings/cpp/src/lib.rs:
##########
@@ -613,6 +613,7 @@ fn new_connection(config: &ffi::FfiConfig) -> Result<*mut 
Connection, String> {
         writer_acks: config.writer_acks.to_string(),
         writer_retries: config.writer_retries,
         writer_batch_size: config.writer_batch_size,
+        writer_batch_timeout_ms: 100,

Review Comment:
   We need to pass the value from config -> 
   `FfiConfig` -`Configuration`(fluss.hpp) - ffi_converter.cpp changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to