LiebingYu commented on code in PR #2757:
URL: https://github.com/apache/fluss/pull/2757#discussion_r2888000420
##########
fluss-common/src/main/java/org/apache/fluss/config/FlussConfigUtils.java:
##########
@@ -77,4 +81,109 @@ static Map<String, ConfigOption<?>>
extractConfigOptions(String prefix) {
}
return options;
}
+
+ public static void validateCoordinatorConfigs(Configuration conf) {
+ validServerConfigs(conf);
+
+ validMinValue(conf, ConfigOptions.DEFAULT_REPLICATION_FACTOR, 1);
+ validMinValue(conf, ConfigOptions.KV_MAX_RETAINED_SNAPSHOTS, 1);
+ validMinValue(conf, ConfigOptions.SERVER_IO_POOL_SIZE, 1);
+
+ // Validate remote.data.dirs
+ List<String> remoteDataDirs = conf.get(ConfigOptions.REMOTE_DATA_DIRS);
+ for (int i = 0; i < remoteDataDirs.size(); i++) {
+ String remoteDataDir = remoteDataDirs.get(i);
+ try {
+ new FsPath(remoteDataDir);
+ } catch (Exception e) {
+ throw new IllegalConfigurationException(
+ String.format(
+ "Invalid remote path for %s at index %d.",
+ ConfigOptions.REMOTE_DATA_DIRS.key(), i),
+ e);
+ }
+ }
+
+ // Validate remote.data.dirs.strategy
+ ConfigOptions.RemoteDataDirStrategy remoteDataDirStrategy =
+ conf.get(ConfigOptions.REMOTE_DATA_DIRS_STRATEGY);
+ if (remoteDataDirStrategy ==
ConfigOptions.RemoteDataDirStrategy.WEIGHTED_ROUND_ROBIN) {
+ List<Integer> weights =
conf.get(ConfigOptions.REMOTE_DATA_DIRS_WEIGHTS);
+ if (!remoteDataDirs.isEmpty() && !weights.isEmpty()) {
+ if (remoteDataDirs.size() != weights.size()) {
+ throw new IllegalConfigurationException(
+ String.format(
+ "The size of '%s' (%d) must match the size
of '%s' (%d) when using WEIGHTED_ROUND_ROBIN strategy.",
+ ConfigOptions.REMOTE_DATA_DIRS.key(),
+ remoteDataDirs.size(),
+
ConfigOptions.REMOTE_DATA_DIRS_WEIGHTS.key(),
+ weights.size()));
+ }
+ // Validate all weights are positive
+ for (int i = 0; i < weights.size(); i++) {
+ if (weights.get(i) < 0) {
+ throw new IllegalConfigurationException(
+ String.format(
+ "All weights in '%s' must be no less
than 0, but found %d at index %d.",
+
ConfigOptions.REMOTE_DATA_DIRS_WEIGHTS.key(),
+ weights.get(i),
+ i));
+ }
+ }
+ }
+ }
+ }
+
+ public static void validateTabletConfigs(Configuration conf) {
+ validServerConfigs(conf);
+
+ Optional<Integer> serverId =
conf.getOptional(ConfigOptions.TABLET_SERVER_ID);
+ if (!serverId.isPresent()) {
+ throw new IllegalConfigurationException(
+ String.format("Configuration %s must be set.",
ConfigOptions.TABLET_SERVER_ID));
+ }
+ validMinValue(ConfigOptions.TABLET_SERVER_ID, serverId.get(), 0);
+
+ validMinValue(conf, ConfigOptions.BACKGROUND_THREADS, 1);
+
+ if (conf.get(ConfigOptions.LOG_SEGMENT_FILE_SIZE).getBytes() >
Integer.MAX_VALUE) {
+ throw new IllegalConfigurationException(
+ String.format(
+ "Invalid configuration for %s, it must be less
than or equal %d bytes.",
+ ConfigOptions.LOG_SEGMENT_FILE_SIZE.key(),
Integer.MAX_VALUE));
+ }
+ }
+
+ /** Validate common server configs. */
+ private static void validServerConfigs(Configuration conf) {
+ if (conf.get(ConfigOptions.REMOTE_DATA_DIR) == null) {
+ throw new IllegalConfigurationException(
Review Comment:
As I updated in the document. We should always set `remote.data.dir`, as the
recently introduced producer offsets and kv snapshot lease files are not belong
to a specific table.
- kv snapshot lease dir:
`{$remote.data.dir}/lease/kv-snapshot/{leaseId}/{tableId}/`
- producer offset dir: `{$remote.data.dir}/producers`
I think we must keep `remote.data.dir` to store producer offsets and kv
snapshot lease files for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
