LiebingYu commented on code in PR #2757:
URL: https://github.com/apache/fluss/pull/2757#discussion_r2903354226
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -96,8 +96,65 @@ public class ConfigOptions {
.stringType()
.noDefaultValue()
.withDescription(
- "The directory used for storing the kv snapshot
data files and remote log for log tiered storage "
- + " in a Fluss supported filesystem.");
+ "The directory in a Fluss supported filesystem for
remote data storage. "
+ + "This configuration is required. "
Review Comment:
I don't think we should set a default value in `ConfigOptions`.
`remote.data.dir` is immutable, so if a user forgets to configure it, the
system should fail fast rather than running with a default value. Providing a
default in `ConfigOptions` might lead users to inadvertently use it, and once
they realize it, they would find that `remote.data.dir` cannot be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
