charlesdong1991 commented on code in PR #427:
URL: https://github.com/apache/fluss-rust/pull/427#discussion_r2892039251
##########
website/docs/user-guide/python/api-reference.md:
##########
@@ -7,25 +7,25 @@ Complete API reference for the Fluss Python client.
## `Config`
-| Method / Property | Description
|
-|---------------------------------------|-----------------------------------------------------------------------------------------|
-| `Config(properties: dict = None)` | Create config from a dict of
key-value pairs |
-| `bootstrap_servers` | Get/set coordinator server address
|
-| `writer_request_max_size` | Get/set max request size in bytes
|
-| `writer_acks` | Get/set acknowledgment setting
(`"all"` for all replicas) |
-| `writer_retries` | Get/set number of retries on failure
|
-| `writer_batch_size` | Get/set write batch size in bytes
|
-| `writer_batch_timeout_ms` | Get/set max time in ms to wait for a
writer batch to fill up before sending |
-| `writer.bucket.no-key-assigner` | Bucket assignment strategy
(`"sticky"` or `"round_robin"`); set via `Config(dict)` only |
-| `scanner_remote_log_prefetch_num` | Get/set number of remote log
segments to prefetch |
-| `remote_file_download_thread_num` | Get/set number of threads for remote
log downloads |
-| `scanner_remote_log_read_concurrency` | Get/set streaming read concurrency
within a remote log file |
-| `scanner_log_max_poll_records` | Get/set max number of records
returned in a single poll() |
-| `connect_timeout_ms` | Get/set TCP connect timeout in
milliseconds |
-| `security_protocol` | Get/set security protocol
(`"PLAINTEXT"` or `"sasl"`) |
-| `security_sasl_mechanism` | Get/set SASL mechanism (only
`"PLAIN"` is supported) |
-| `security_sasl_username` | Get/set SASL username (required when
protocol is `"sasl"`) |
-| `security_sasl_password` | Get/set SASL password (required when
protocol is `"sasl"`) |
+| Method / Property | Config Key
| Description
|
+|---------------------------------------|---------------------------------------|-----------------------------------------------------------------------------------------|
+| `Config(properties: dict = None)` |
| Create config from a dict of key-value pairs
|
+| `bootstrap_servers` | `bootstrap.servers`
| Get/set coordinator server address
|
+| `writer_request_max_size` | `writer.request-max-size`
| Get/set max request size in bytes
|
+| `writer_acks` | `writer.acks`
| Get/set acknowledgment setting (`"all"` for all replicas)
|
+| `writer_retries` | `writer.retries`
| Get/set number of retries on failure
|
+| `writer_batch_size` | `writer.batch-size`
| Get/set write batch size in bytes
|
+| `writer_batch_timeout_ms` | `writer.batch-timeout-ms`
| Get/set max time in ms to wait for a writer batch to fill up before sending
|
+| `writer_bucket_no_key_assigner` | `writer.bucket.no-key-assigner`
| Get/set bucket assignment strategy (`"sticky"` or `"round_robin"`)
|
Review Comment:
this property seems to be mis-spelled, and also description is outdated as
well because it now has both setter and getter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
