charlesdong1991 commented on code in PR #427:
URL: https://github.com/apache/fluss-rust/pull/427#discussion_r2892052899
##########
website/docs/user-guide/cpp/example/configuration.md:
##########
@@ -23,21 +23,7 @@ if (!result.Ok()) {
All fields have sensible defaults. Only `bootstrap_servers` typically needs to
be set.
-```cpp
-fluss::Configuration config;
-config.bootstrap_servers = "127.0.0.1:9123"; // Coordinator
address
-config.writer_request_max_size = 10 * 1024 * 1024; // Max request
size (10 MB)
-config.writer_acks = "all"; // Wait for all
replicas
-config.writer_retries = std::numeric_limits<int32_t>::max(); // Retry on
failure
-config.writer_batch_size = 2 * 1024 * 1024; // Batch size (2
MB)
-config.writer_batch_timeout_ms = 100; // Max time to
wait for a batch to fill
-config.writer_bucket_no_key_assigner = "sticky"; // "sticky" or
"round_robin"
-config.scanner_remote_log_prefetch_num = 4; // Remote log
prefetch count
-config.remote_file_download_thread_num = 3; // Download
threads
-config.scanner_remote_log_read_concurrency = 4; // In-file
remote log read concurrency
-config.scanner_log_max_poll_records = 500; // Max records
per poll
-config.connect_timeout_ms = 120000; // TCP connect
timeout (ms)
-```
+See the [`Configuration`](../api-reference.md#configuration) section in the
API Reference for the full list of configuration fields, types, and defaults.
Review Comment:
Different from what was proposed in the GH Issue, i think it's better to
replace the duplicates in configuration.md in examples/, and reference
api-reference instead.
Because configuration lives in examples, so intuitively to me, its primary
role is showing how to use config with code examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
