gyang94 commented on code in PR #2769:
URL: https://github.com/apache/fluss/pull/2769#discussion_r2901473203
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -692,13 +696,14 @@ public Set<String> getPartitions(TablePath tablePath) {
public void createPartition(
TablePath tablePath,
long tableId,
+ String remoteDataDir,
Review Comment:
I am thinking about possible improvements here:
1.
Will it be better to put the remote dir selection logic inside into the
`MetadataManager.createPartition()` and `MetadataManager.createTable()`.
I notice that now there exist some code pattern that (a). select a
remoteDataDir value. (b) pass the value into createTable/createPartition
functions, when we need to createTable/partition otherwhere.
Put the step(a) inside those functions will make the code more focused and
void adding a remoteDataDir parameter in these functions.
Or
2.
Is is good to add the 'remoteDataDir' field into the `TablePath` class? Make
the TablePath object carrys the remote dir info, and pass it through to
everywhere. Then we don't need to care about adding an independent
remoteDataDir parameter in functions which already has the TablePath parameter.
The implementation now is good to work. Just put my thoughts here. What do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
