LiebingYu commented on code in PR #2769:
URL: https://github.com/apache/fluss/pull/2769#discussion_r2916330565
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/MetadataManager.java:
##########
@@ -692,13 +696,14 @@ public Set<String> getPartitions(TablePath tablePath) {
public void createPartition(
TablePath tablePath,
long tableId,
+ String remoteDataDir,
Review Comment:
1. Put the selection into `MetadataManager` also need to change a lot. By
comparison, I think the current approach would actually introduce smaller
changes.
2. `TablePath` represents the logical path of a Fluss table, while
`remoteDataDir` is the physical storage path in the implementation. I don’t
think it’s appropriate to put `remoteDataDir` into `TablePath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
