swuferhong commented on code in PR #2780:
URL: https://github.com/apache/fluss/pull/2780#discussion_r2946221197
##########
fluss-server/src/main/java/org/apache/fluss/server/zk/data/ZkData.java:
##########
@@ -305,13 +305,44 @@ public static String path() {
//
------------------------------------------------------------------------------------------
/**
- * The znode for the active coordinator. The znode path is:
+ * The znode for alive coordinators. The znode path is:
*
- * <p>/coordinators/active
+ * <p>/coordinators/ids
+ */
+ public static final class CoordinatorIdsZNode {
+ public static String path() {
+ return "/coordinators/ids";
+ }
+ }
+
+ /**
+ * The znode for a registered Coordinator information. The znode path is:
+ *
+ * <p>/coordinators/ids/[serverId]
+ */
+ public static final class CoordinatorIdZNode {
+ public static String path(int serverId) {
+ return CoordinatorIdsZNode.path() + "/" + serverId;
+ }
+ }
+
+ /**
+ * The znode for the coordinator leader election. The znode path is:
+ *
+ * <p>/coordinators/election
+ */
+ public static final class CoordinatorElectionZNode {
+ public static String path() {
+ return "/coordinators/election";
+ }
+ }
+
+ /**
+ * The znode for the active coordinator leader. The znode path is:
*
- * <p>Note: introduce standby coordinators in the future for znode
"/coordinators/standby/".
+ * <p>/coordinators/leader
Review Comment:
`/coordinators/leader` or `/coordinators/active`？ The below path is
`/coordinators/active`
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -341,6 +341,12 @@ public class ConfigOptions {
+ " (“50100,50101”), ranges
(“50100-50200”) or a combination of both."
+ "This option is deprecated. Please use
bind.listeners instead, which provides a more flexible configuration for
multiple ports");
+ public static final ConfigOption<Integer> COORDINATOR_ID =
+ key("coordinator.id")
+ .intType()
Review Comment:
As defined in the FIP, the `coordinator.id` should be a UUID instead of an
integer. Please modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
