wuchong commented on PR #2780: URL: https://github.com/apache/fluss/pull/2780#issuecomment-4162322669
I pushed a commit to improve some code and squash commits. 1. `@RequireCoordinatorLeader` annotation has no enforcement It's purely documentary, requiring developers to manually add `checkLeader()`. This is error-prone (as proven by the `alterDatabase` miss to add the `checkLeader`). I refactored it into check leader in `FlussRequestHandler#processRequest` for all requests to `CoordinatorService`. This also removes the `RequireCoordinatorLeader` annotation class. 2. `leaderReadyFuture` in CoordinatorLeaderElection` is not necessary. 3. Refactor `CoordinatorServer` to reuse the zk retry loop logic 4. Refactor `CoordinatorLeaderElection` to reuse a cached thread pool, rather than start `Thread` instance. I will merge this PR if you don't have any objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
