charlesdong1991 commented on code in PR #576:
URL: https://github.com/apache/fluss-rust/pull/576#discussion_r3320234206
##########
crates/fluss/src/record/kv/value_record_batch.rs:
##########
@@ -75,7 +75,7 @@ impl ValueRecordBatch {
}
/// Returns one byte range per record, each spanning `[SchemaId | Value]`:
- /// the payload [`crate::row::FixedSchemaDecoder::decode`] expects. Index
+ /// the payload that `FixedSchemaDecoder::decode` expects. Index
Review Comment:
so warning is:
```
error: public documentation for `value_ranges` links to private item
`crate::row::FixedSchemaDecoder::decode`
```
so IMHO linting is correct, link points to something that doesn't exist in
public doc output. we can fix by making this `FixedSchemaDecoder` pub (which i
feel unless is intentional, maybe not to expand public api), or allow private
intra doc links for this value_ranges...
not sure if either is better, i went with not touching codebase, but happy
to pick any option you prefer as i don't have strong preference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
