leekeiabstraction commented on code in PR #576:
URL: https://github.com/apache/fluss-rust/pull/576#discussion_r3320299444
##########
crates/fluss/src/record/kv/value_record_batch.rs:
##########
@@ -75,7 +75,7 @@ impl ValueRecordBatch {
}
/// Returns one byte range per record, each spanning `[SchemaId | Value]`:
- /// the payload [`crate::row::FixedSchemaDecoder::decode`] expects. Index
+ /// the payload that `FixedSchemaDecoder::decode` expects. Index
Review Comment:
Gotcha. If I understand correctly, these (ValueRecordBatch and
FixedSchemaDecoder) are mainly internals of fluss-rust. Agree with removing the
link as valuable this is not as valuable in internal functions. I might go one
step further and make these `pub (crate)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
