Yohahaha commented on code in PR #3397:
URL: https://github.com/apache/fluss/pull/3397#discussion_r3330158744
##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/FlussScanBuilder.scala:
##########
@@ -96,8 +98,11 @@ trait FlussLakeSupportsPushDownV2Filters extends
FlussSupportsPushDownV2Filters
def flussConfig: FlussConfiguration
override def pushPredicates(predicates: Array[Predicate]): Array[Predicate]
= {
+ val nonPartitionPredicates = super.pushPredicates(predicates)
Review Comment:
I did a small refactor on filter pushdown. Lake and non-lake paths can now
implement
pushdown logic freely. The common partition pushdown logic is in the parent
class.
You can see the new interface and class inheritance structure below
```
SupportsPushDownV2Filters (Spark)
│
└── FlussSupportsPushDownPartitionFilters
│
├── FlussSupportsPushDownV2Filters
│ │
│ ├── FlussAppendScanBuilder
│ └── FlussUpsertScanBuilder
│
└── FlussLakeSupportsPushDownV2Filters
│
├── FlussLakeAppendScanBuilder
└── FlussLakeUpsertScanBuilder
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
