fresh-borzoni commented on code in PR #3397:
URL: https://github.com/apache/fluss/pull/3397#discussion_r3331252802
##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/FlussScanBuilder.scala:
##########
@@ -163,7 +166,7 @@ class FlussUpsertScanBuilder(
val tableInfo: TableInfo,
options: CaseInsensitiveStringMap,
val flussConfig: FlussConfiguration)
- extends FlussSupportsPushDownPartitionFilters {
+ extends FlussSupportsPushDownV2Filters {
Review Comment:
For PK we read from the KV snapshot and never apply ARROW filters - so
convertAndStorePredicates just gets thrown away, and pushedPredicates() reports
filters the scan doesn't apply. Results are still fine (Spark re-checks them),
just wasted work + misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
