leekeiabstraction commented on code in PR #581:
URL: https://github.com/apache/fluss-rust/pull/581#discussion_r3332355019
##########
crates/fluss/src/metrics.rs:
##########
@@ -160,6 +171,7 @@ impl ScannerMetrics {
Self {
time_between_poll_ms: scanner_gauge(SCANNER_TIME_BETWEEN_POLL_MS,
database, table),
poll_idle_ratio: scanner_gauge(SCANNER_POLL_IDLE_RATIO, database,
table),
+ last_poll_seconds_ago:
scanner_gauge(SCANNER_LAST_POLL_SECONDS_AGO, database, table),
Review Comment:
`scanner_gauge` is keyed by database and table. What if there are two
scanners (with different projections for example) running and one of them is
stuck? Is there a risk that metric of the healthy one overwrites/gets emitted
over the value of the stuck one and consequently alert is not raised?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
