charlesdong1991 commented on code in PR #581:
URL: https://github.com/apache/fluss-rust/pull/581#discussion_r3336446586
##########
crates/fluss/src/metrics.rs:
##########
@@ -160,6 +171,7 @@ impl ScannerMetrics {
Self {
time_between_poll_ms: scanner_gauge(SCANNER_TIME_BETWEEN_POLL_MS,
database, table),
poll_idle_ratio: scanner_gauge(SCANNER_POLL_IDLE_RATIO, database,
table),
+ last_poll_seconds_ago:
scanner_gauge(SCANNER_LAST_POLL_SECONDS_AGO, database, table),
Review Comment:
good call, it doesn't cover per-scanner dimension. I also checked on Java
side, seems also not there, and actually i think it's best to create an issue
in fluss and seek for feedback and implement there first, and then match here.
wdyt? happy to create issue and contribute there first if you agree with
assessment 🙏 thanks @leekeiabstraction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
