wattt3 commented on code in PR #3427:
URL: https://github.com/apache/fluss/pull/3427#discussion_r3360534126
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java:
##########
@@ -687,7 +687,9 @@ public void flush(long exclusiveUpToLogOffset,
FatalErrorHandler fatalErrorHandl
} else {
try {
int rowCountDiff =
kvPreWriteBuffer.flush(exclusiveUpToLogOffset);
- flushedLogOffset = exclusiveUpToLogOffset;
+ if (exclusiveUpToLogOffset > flushedLogOffset) {
Review Comment:
Wrapping the flush() + rowCount update inside the if is fully equivalent and
reads better.
I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
