wattt3 commented on code in PR #3427:
URL: https://github.com/apache/fluss/pull/3427#discussion_r3362643511
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java:
##########
@@ -687,7 +687,9 @@ public void flush(long exclusiveUpToLogOffset,
FatalErrorHandler fatalErrorHandl
} else {
try {
int rowCountDiff =
kvPreWriteBuffer.flush(exclusiveUpToLogOffset);
- flushedLogOffset = exclusiveUpToLogOffset;
+ if (exclusiveUpToLogOffset > flushedLogOffset) {
Review Comment:
@platinumhamburg
I tried moving the guard before kvPreWriteBuffer.flush(), but it broke some
tests that call flush(exclusiveUpToLogOffset = Long.MAX_VALUE).
Once flushedLogOffset reaches MAX, the guard skips the later flushes.
I could adjust those tests to make the move work, but I'd lean toward
keeping it as is.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
