Prajwal-banakar commented on code in PR #3398:
URL: https://github.com/apache/fluss/pull/3398#discussion_r3368797068
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkCatalog.java:
##########
@@ -746,19 +760,24 @@ public void alterPartition(
}
@Override
- public List<String> listFunctions(String s) throws
DatabaseNotExistException, CatalogException {
- return Collections.emptyList();
+ public List<String> listFunctions(String dbName)
+ throws DatabaseNotExistException, CatalogException {
+ return new ArrayList<>(BUILTIN_BITMAP_FUNCTIONS.keySet());
}
@Override
- public CatalogFunction getFunction(ObjectPath functionPath)
- throws FunctionNotExistException, CatalogException {
- throw new FunctionNotExistException(getName(), functionPath);
+ public boolean functionExists(ObjectPath objectPath) throws
CatalogException {
+ return
BUILTIN_BITMAP_FUNCTIONS.containsKey(objectPath.getObjectName().toLowerCase());
}
@Override
- public boolean functionExists(ObjectPath objectPath) throws
CatalogException {
- return false;
+ public CatalogFunction getFunction(ObjectPath functionPath)
+ throws FunctionNotExistException, CatalogException {
+ String className =
BUILTIN_BITMAP_FUNCTIONS.get(functionPath.getObjectName().toLowerCase());
Review Comment:
Done, using Locale.ROOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
