platinumhamburg commented on PR #3398: URL: https://github.com/apache/fluss/pull/3398#issuecomment-4646253496
> polyzos Thanks to @Prajwal-banakar for the contribution and to polyzos for the thorough review. Regarding the built-in registration issue, I agree with polyzos’s view: given that we do not expect a large number of new functions to be added in the foreseeable future, and since these functions do not require authentication or categorized management, the current implementation is acceptable. > Hi @polyzos Thanks for review and rememberring this RbFunctionsCatalogITCase as important! initially i plan to add all the phase 1 functions and after that add `RbFunctionsCatalogITCase` howevever, > > 1. Added RbFunctionsCatalogITCase with four tests exercising all three functions through the catalog registration path using a real TableEnvironment. Happy to extend this further. > 2. On the registration design question: I will wait for @platinumhamburg and @wuchong input on this before making changes. Thanks to @Prajwal-banakar for the contribution and to @polyzos for the thorough review. Regarding the built-in registration issue, I agree with @polyzos’s view: given that we do not expect a large number of new functions to be added in the foreseeable future, and since these functions do not require authentication or categorized management, the current implementation is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
