Jackeyzhe opened a new pull request, #3494:
URL: https://github.com/apache/fluss/pull/3494
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos
in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were
used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the
guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #3483
This PR fixes a race where a stale V2 lake snapshot commit can be accepted
after a table is dropped and recreated. In that case, the recreated table may
get a `/laketable` znode pointing to an offsets metadata file generated for the
old table id, causing lake tiering to repeatedly fail when reading the stale
offsets path.
<!-- What is the purpose of the change -->
### Brief change log
- Reject V2 lake snapshot commits when the target table id no longer exists
or is queued for deletion.
- Validate the V2 lake snapshot offsets metadata before writing it to ZK:
- the offsets file must be readable;
- the file-level `tableId` must match the commit table id;
- every `TableBucket` in the offsets file must also belong to the commit
table id.
- Validate both tiered offsets and readable offsets metadata paths when they
differ.
- Add regression coverage for:
- non-existent table id commits;
- table queued for deletion;
- recreated table id with stale offsets metadata from the old table id;
- RPC-level V2 commit after table drop.
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
``` bash
mvn -pl fluss-server -DskipITs -Dcheckstyle.skip -Drat.skip
-Dspotless.check.skip=true
-Dtest=CoordinatorEventProcessorTest#testCommitLakeTableSnapshotV2RejectsMismatchedOffsetsFileTableId+testCommitLakeTableSnapshotV2RejectsNonExistentTable+testCommitLakeTableSnapshotV2RejectsQueuedForDeletionTable
test
```
``` bash
mvn -pl fluss-server -DskipITs -Dcheckstyle.skip -Drat.skip
-Dspotless.check.skip=true
-Dtest=CommitLakeTableSnapshotITCase#testCommitLakeTableSnapshotV2RejectedAfterDropTable
test
```
<!-- List UT and IT cases to verify this change -->
### API and Format
no
<!-- Does this change affect API or storage format -->
### Documentation
no
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
