luoyuxia commented on code in PR #3494:
URL: https://github.com/apache/fluss/pull/3494#discussion_r3464404239
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java:
##########
@@ -2145,6 +2135,16 @@ private void handleCommitLakeTableSnapshotV2(
});
}
+ private void ensureTableCanAcceptLakeSnapshot(long tableId) {
Review Comment:
nit: rename to ensureTableNotDeleted? I can image maybe other event maywell
need this method.
##########
fluss-server/src/test/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessorTest.java:
##########
@@ -1585,6 +1565,108 @@ void testLeaderOnlyRebalanceExecutesSequentially()
throws Exception {
verifyIsr(tb2, 1, Arrays.asList(0, 1, 2));
}
+ @Test
+ void testCommitLakeTableSnapshotV2RejectsNonExistentTable() throws
Exception {
Review Comment:
nit: I think we can remove the ut since
testCommitLakeTableSnapshotV2RejectedAfterDropTable alreay cover it. I want to
keep this test class short if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
