VladBanar commented on code in PR #3447:
URL: https://github.com/apache/fluss/pull/3447#discussion_r3461970243
##########
fluss-client/src/main/java/org/apache/fluss/client/converter/FlussTypeToPojoTypeConverter.java:
##########
@@ -31,9 +31,30 @@
import java.time.LocalTime;
import java.time.OffsetDateTime;
import java.time.ZoneOffset;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
/** Shared utilities for Fluss type and Pojo type. */
public class FlussTypeToPojoTypeConverter {
+
+ private static final Map<Class<?>, Map<String, Object>>
ENUM_CONSTANTS_CACHE =
+ new ConcurrentHashMap<>();
+
+ /**
+ * Builds a map of enum name (uppercase) to enum constant for the given
enum class. This map is
+ * cached to avoid recreating it for every enum conversion.
+ */
+ private static Map<String, Object> buildEnumConstantsMap(Class<?>
enumClass) {
+ Map<String, Object> map = new HashMap<>();
+ for (Object constant : enumClass.getEnumConstants()) {
+ map.put(constant.toString(), constant);
Review Comment:
done
##########
fluss-client/src/main/java/org/apache/fluss/client/converter/FlussTypeToPojoTypeConverter.java:
##########
@@ -31,9 +31,30 @@
import java.time.LocalTime;
import java.time.OffsetDateTime;
import java.time.ZoneOffset;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
/** Shared utilities for Fluss type and Pojo type. */
public class FlussTypeToPojoTypeConverter {
+
+ private static final Map<Class<?>, Map<String, Object>>
ENUM_CONSTANTS_CACHE =
Review Comment:
Oh i see what you mean now. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
