VladBanar commented on code in PR #3447:
URL: https://github.com/apache/fluss/pull/3447#discussion_r3461973517
##########
fluss-client/src/main/java/org/apache/fluss/client/converter/ConverterCommons.java:
##########
@@ -148,6 +148,15 @@ static void validateCompatibility(DataType fieldType,
PojoType.Property prop) {
}
return;
}
+ if (actual.isEnum()) {
+ if (typeRoot != DataTypeRoot.STRING) {
+ throw new IllegalArgumentException(
+ String.format(
+ "Enum field '%s' must be a string type, got
%s",
Review Comment:
For me, it's the same. But changed the wording.
##########
fluss-client/src/test/java/org/apache/fluss/client/converter/ConvertersTestFixtures.java:
##########
@@ -151,6 +155,7 @@ public static TestPojo sample() {
put("test_2", 2);
}
},
+ StatusEnum.OK,
Review Comment:
added another test with lowercase enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
