loserwang1024 commented on code in PR #3511:
URL: https://github.com/apache/fluss/pull/3511#discussion_r3490296468
##########
fluss-server/src/main/java/org/apache/fluss/server/RpcServiceBase.java:
##########
@@ -634,6 +651,12 @@ protected MetadataResponse processMetadataRequest(
if (partitionIdAndPaths.containsKey(partitionId)) {
partitionPaths.add(partitionIdAndPaths.get(partitionId));
} else {
+ // Only cache when the authoritative partition assignment
is also gone. A miss
+ // from the scoped table-path lookup may simply mean that
the request omitted
+ // the owning table or the session is not authorized for
it.
+ if (isPartitionAssignmentMissingFromZk(partitionId)) {
Review Comment:
Look good to me, only one mirror problem: whether partitionId in
partitionIdsNotExistsInCache is included in partitionNegativeCache? If not,
this is no need. Maybe this can move blew `partitionIdAndPaths =
zkClient.getPartitionIdAndPaths(authorizedTables)` for each existed
partitionIdAndPaths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
