nicolazar opened a new pull request, #647:
URL: https://github.com/apache/fluss-rust/pull/647
<!--
*Thank you very much for contributing to Fluss - we are happy that you want
to help us improve Fluss. To help the community review your contribution in the
best possible way, please go through the checklist below, which will get the
contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/fluss-rust/issues). Exceptions are made for
typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull
request", where *[component]* should be replaced by the name of the component
being changed. Typically, this corresponds to the component label assigned to
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are
unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
This PR brings the Elixir's `create_table` descriptor to full parity with
the native builder by also supporting `:bucket_keys`, `:partition_keys`,
`:custom_properties` & `comment`, in addition to `bucket_count` and
`properties`. These options are already surfaced on the read side in #640.
<!-- Linking this pull request to the issue -->
Linked issue: close #642
<!-- What is the purpose of the change -->
### Brief change log
- Add the four new options to `Fluss.TableDescriptor.new!/2`.
- Bundle the optional fields into a `Fluss.TableDescriptor.Options` struct,
decoded across the NIF as a `NifStruct` (`NifTableOptions`) instead of a long
positional NIF signature.
- Build the core descriptor with unconditional
`.properties/.custom_properties/.partitioned_by/.distributed_by` calls
- Change `:properties` from a list of `{k, v}` tuples to a map, matching
`:custom_properties` and the map already returned by `get_table_info`.
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
### Tests
New unit tests for the all-options constructions and integration tests which
round-trips `comment`, `custom_properties`, explicit `bucket_keys`, and
`partition_keys` via `get_table_info`.
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
Elixir-only API change. `:properties` changes from a keyword/tuple list to a
map for parity with the read side; no existing caller passed `:properties`.
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
