Guosmilesmile opened a new pull request, #3552:
URL: https://github.com/apache/fluss/pull/3552

   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   Currently `PrometheusPushGatewayReporter` sends metrics to the Prometheus 
PushGateway anonymously. In production, PushGateway is often placed behind has 
its own basic auth enabled, which makes the reporter unusable in secured 
deployments.
   
   This PR adds first-class support for Basic Auth on the `prometheus-push` 
reporter.
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   - Add two new config options:
     - `metrics.reporter.prometheus-push.username`
     - `metrics.reporter.prometheus-push.password`
   - `PrometheusPushGatewayReporter` now injects
     `io.prometheus.client.exporter.BasicAuthHttpConnectionFactory` into the
     underlying `PushGateway` when a username is configured; otherwise the
     behavior is unchanged (no `Authorization` header is sent).
   - `PrometheusPushGatewayReporterPlugin` reads the two new options and
     passes them to the reporter. A `basicAuthEnabled` flag is logged
     instead of the raw credentials, so passwords are never printed.
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   Add the config to the doc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to