Copilot commented on code in PR #3523:
URL: https://github.com/apache/fluss/pull/3523#discussion_r3517935091
##########
fluss-server/src/main/java/org/apache/fluss/server/utils/TableDescriptorValidation.java:
##########
@@ -179,6 +186,13 @@ public static void validateAlterTableProperties(
ConfigOptions.TABLE_KV_STANDBY_REPLICA_ENABLED.key()));
}
+ if (customKeysToChange.contains(PAIMON_PATH_KEY) &&
currentConfig.isDataLakeEnabled()) {
+ throw new InvalidAlterTableException(
+ String.format(
+ "'%s' can only be altered when datalake is
disabled.",
+ PAIMON_PATH_KEY));
+ }
Review Comment:
The new paimon.path alter restriction currently applies to *any*
datalake-enabled table, regardless of the table’s configured datalake format.
This can incorrectly block altering an unrelated custom property named
"paimon.path" on ICEBERG/LANCE/HUDI tables. The check should be gated on the
table’s datalake format being PAIMON (or on an absent format, if you
intentionally want to treat legacy tables as PAIMON).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
