wzx140 commented on PR #3523: URL: https://github.com/apache/fluss/pull/3523#issuecomment-4891503073
> @wzx140 Thnaks for update. Do we need to add `tableExists` to the generic `LakeCatalog` interface for this? > > The current validation seems specific to Paimon's `paimon.path` option. Adding a generic `LakeCatalog.tableExists(...)` makes all lake formats implement a new public contract, but Iceberg/Hudi/Lance currently just throw `UnsupportedOperationException`, so the interface contract is not really supported generically. > > Could we keep this validation inside the Paimon implementation instead? That would avoid expanding the generic lake catalog API for a Paimon-specific rule. @luoyuxia Thanks for the suggestion. I moved the validation into the Paimon catalog side. Now `paimon.path` is checked in `PaimonLakeCatalog.alterTable`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
