beryllw commented on code in PR #3617:
URL: https://github.com/apache/fluss/pull/3617#discussion_r3542111122
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/FlinkSource.java:
##########
@@ -290,7 +290,8 @@ public SourceReader<OUT, SourceSplitBase>
createReader(SourceReaderContext conte
flussConf.set(
Review Comment:
Just a personal question, might be missing something here — since flussConf
is a member field of the source, calling set seems to mutate it in place, and
this config eventually gets passed down to the Connection and shared by the
downstream scanners. So I'm wondering whether multiple readers reusing the same
instance could end up sharing the same config. Would it be safer to copy it
first before setting？
Curious how you see it @luoyuxia ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
